[
https://issues.apache.org/jira/browse/FLINK-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466138#comment-16466138
]
ASF GitHub Bot commented on FLINK-9253:
---------------------------------------
Github user NicoK commented on the issue:
https://github.com/apache/flink/pull/5923
Apparently, there's a problem with unknown input channels that surfaced
with the newly-merged extra tests: they don't get exclusive buffers (naturally)
but the floating buffers are calculated and would need to be updated when the
channels' types are known.
I'll take a look in the next few days.
> Make buffer count per InputGate always #channels*buffersPerChannel +
> ExclusiveBuffers
> -------------------------------------------------------------------------------------
>
> Key: FLINK-9253
> URL: https://issues.apache.org/jira/browse/FLINK-9253
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.5.0, 1.6.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Fix For: 1.5.0
>
>
> The credit-based flow control path assigns exclusive buffers only to remote
> channels (which makes sense since local channels don't use any own buffers).
> However, this is a bit intransparent with respect to how much data may be in
> buffers since this depends on the actual schedule of the job and not the job
> graph.
> By adapting the floating buffers to use a maximum of
> {{#channels*buffersPerChannel + floatingBuffersPerGate - #exclusiveBuffers}},
> we would be channel-type agnostic and keep the old behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
