[ 
https://issues.apache.org/jira/browse/FLINK-2322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14635537#comment-14635537
 ] 

ASF GitHub Bot commented on FLINK-2322:
---------------------------------------

GitHub user tedyu opened a pull request:

    https://github.com/apache/flink/pull/928

    FLINK-2322 Unclosed stream may leak resource

    What size should I use for tab ?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tedyu/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #928
    
----
commit c4a16ce1910b7ac53ee63a4ac9c1d85299e16204
Author: tedyu <[email protected]>
Date:   2015-07-21T18:13:17Z

    FLINK-2322 Unclosed stream may leak resource

----


> Unclosed stream may leak resource
> ---------------------------------
>
>                 Key: FLINK-2322
>                 URL: https://issues.apache.org/jira/browse/FLINK-2322
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Ted Yu
>              Labels: starter
>
> In UdfAnalyzerUtils.java :
> {code}
>         ClassReader cr = new 
> ClassReader(Thread.currentThread().getContextClassLoader()
>             .getResourceAsStream(internalClassName.replace('.', '/') + 
> ".class"));
> {code}
> The stream returned by getResourceAsStream() should be closed upon exit of 
> findMethodNode()
> In ParameterTool#fromPropertiesFile():
> {code}
>     props.load(new FileInputStream(propertiesFile));
> {code}
> The FileInputStream should be closed before returning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to