Github user makeyang commented on a diff in the pull request:
https://github.com/apache/flink/pull/5908#discussion_r187296892
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimer.java
---
@@ -97,6 +105,32 @@ public String toString() {
'}';
}
+ public String buildHashKey() {
+ return this.hashKey;
+ }
+
+ public static String buildHashKey(String key, String namespace, long
timestamp) {
+ return key + ":" + namespace + ":" + timestamp;
+ }
+
+ public void markDelete(int deleteVersion) {
+ synchronized (this.deleteVersion) {
--- End diff --
I agree with u that this synchronization can be replaced by volatile
---
