[
https://issues.apache.org/jira/browse/FLINK-9292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471796#comment-16471796
]
ASF GitHub Bot commented on FLINK-9292:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/5970#discussion_r187592909
--- Diff:
flink-java/src/test/java/org/apache/flink/api/java/sca/UdfAnalyzerTest.java ---
@@ -268,8 +274,8 @@ public void
testForwardIntoNestedTupleWithVarAndModification() {
@Test
public void testForwardIntoTupleWithAssignment() {
-
compareAnalyzerResultWithAnnotationsSingleInput(MapFunction.class, Map14.class,
"Tuple2<String,Integer>",
- "Tuple2<String,String>");
+
compareAnalyzerResultWithAnnotationsSingleInput(MapFunction.class, Map14.class,
+ TypeInformation.of(new TypeHint<Tuple2<String,
Integer>>(){}), TypeInformation.of(new TypeHint<Tuple2<String, String>>(){}));
--- End diff --
There is so much use of the types `Tuple2<String, Integer>>` and
`Tuple2<String, String>`, it would make sense to factor these out into a static
field and reference them from there.
> Remove TypeInfoParser
> ---------------------
>
> Key: FLINK-9292
> URL: https://issues.apache.org/jira/browse/FLINK-9292
> Project: Flink
> Issue Type: Task
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> The {{TypeInfoParser}} has been deprecated, in favor of the {{TypeHint}}.
> Because the TypeInfoParser is also not working correctly with respect to
> classloading, we should remove it. Users still find the class, try to use it,
> and run into problems.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
