Github user kailashhd commented on a diff in the pull request:
https://github.com/apache/flink/pull/5992#discussion_r187630051
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/config/ConsumerConfigConstants.java
---
@@ -66,13 +66,13 @@ public SentinelSequenceNumber
toSentinelSequenceNumber() {
public static final String STREAM_TIMESTAMP_DATE_FORMAT =
"flink.stream.initpos.timestamp.format";
/** The base backoff time between each describeStream attempt. */
- public static final String STREAM_DESCRIBE_BACKOFF_BASE =
"flink.stream.describe.backoff.base";
--- End diff --
Would it be better to include a new set of constants for listShards?
Semantically this is equivalent, so having the same names for listShards should
be okay but a little bit confusing.
---
