Github user medcv commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6000#discussion_r187802397
  
    --- Diff: docs/dev/stream/operators/windows.md ---
    @@ -730,9 +730,9 @@ input
     
     /* ... */
     
    -public class MyProcessWindowFunction implements 
ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
    +public static class MyProcessWindowFunction extends 
ProcessWindowFunction<Tuple<String, Long>, String, String, TimeWindow> {
    --- End diff --
    
    make sense! 
    I see some `static` in this docs for other examples, we might need to make 
them consistent
    
    `private static class MyReduceFunction implements 
ReduceFunction<SensorReading> {`


---

Reply via email to