[ 
https://issues.apache.org/jira/browse/FLINK-8910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473805#comment-16473805
 ] 

ASF GitHub Bot commented on FLINK-8910:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5676#discussion_r187842776
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java 
---
    @@ -140,7 +140,8 @@
     
        public static final ConfigOption<Long> SLOT_IDLE_TIMEOUT =
                key("slot.idle.timeout")
    -                   .defaultValue(10L * 1000L)
    +                   // default matches heartbeat.timeout so that sticky 
allocation is not lost on timeouts for local recovery
    +                   
.defaultValue(HeartbeatManagerOptions.HEARTBEAT_TIMEOUT.defaultValue())
    --- End diff --
    
    reminder: if this results in a different default value, I would suggest to 
make a note of the change in the "Release Notes" field of the JIRA ticket.


> Introduce automated end-to-end test for local recovery (including sticky 
> scheduling)
> ------------------------------------------------------------------------------------
>
>                 Key: FLINK-8910
>                 URL: https://issues.apache.org/jira/browse/FLINK-8910
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.5.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should have an automated end-to-end test that can run nightly to check 
> that sticky allocation and local recovery work as expected.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to