Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5761#discussion_r187847923
--- Diff:
flink-end-to-end-tests/test-scripts/test_streaming_elasticsearch1.sh ---
@@ -0,0 +1,66 @@
+#!/usr/bin/env bash
+################################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+################################################################################
+
+# End to end test for ElasticsearchSink1.x.
--- End diff --
Can we have a single script for all Elasticsearch versions?
It doesn't seem right that we have 3 scripts we a lot of duplicate bash
code.
---
