[
https://issues.apache.org/jira/browse/FLINK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473822#comment-16473822
]
ASF GitHub Bot commented on FLINK-8989:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/5761#discussion_r187847498
--- Diff:
flink-end-to-end-tests/flink-elasticsearch1-test/src/main/java/org/apache/flink/elasticsearch1/test/Elasticsearch1SinkExample.java
---
@@ -37,20 +38,33 @@
import java.util.Map;
/**
- * This example shows how to use the Elasticsearch Sink. Before running it
you must ensure that
- * you have a cluster named "elasticsearch" running or change the cluster
name in the config map.
+ * End to end test for Elasticsearch1Sink.
+ *
+ * <p>This example shows how to use the Elasticsearch1 Sink from an user
endpoint. Before running it you
+ * must ensure that you have a cluster named "elasticsearch" running or
change the cluster name in the config map.
--- End diff --
This Javadoc doesn't make sense when considering it as a job simply used in
end-to-end tests.
> End-to-end test: ElasticSearch connector
> ----------------------------------------
>
> Key: FLINK-8989
> URL: https://issues.apache.org/jira/browse/FLINK-8989
> Project: Flink
> Issue Type: Sub-task
> Components: ElasticSearch Connector, Tests
> Reporter: Till Rohrmann
> Assignee: mingleizhang
> Priority: Major
>
> Similar to FLINK-8988 we should add a end-to-end test which tests the
> {{ElasticSearch}} connector. We should run against all three supported
> ElasticSearch versions: 1.x, 2.x and 5.x.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
