[
https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473859#comment-16473859
]
ASF GitHub Bot commented on FLINK-9325:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/5982
Thanks for preparing this.
I looked at the `TwoPhraseFSDatautputStream` - maybe we can make this
simpler. Do we need the distinction between phases? Is it not enough to behave
as a regular stream, just overriding `close()` to do `super.close()` +
`rename()`? That may be enough. When the stream is closed, all the writing
methods anyways fail with a "stream closed exception".
Also, we need this method to be implemented in all FileSystem subclasses.
Typos: "Phrase" --> "Phase"
> generate the _meta file for checkpoint only when the writing is truly
> successful
> --------------------------------------------------------------------------------
>
> Key: FLINK-9325
> URL: https://issues.apache.org/jira/browse/FLINK-9325
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
>
> We should generate the _meta file for checkpoint only when the writing is
> totally successful. We should write the metadata file first to a temp file
> and then atomically rename it (with an equivalent workaround for S3).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
