[ 
https://issues.apache.org/jira/browse/FLINK-9176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473954#comment-16473954
 ] 

ASF GitHub Bot commented on FLINK-9176:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6005

    [FLINK-9176][tests] Remove category annotations

    Subsumes #5851.
    
    ## What is the purpose of the change
    
    This PR removes the category annotations that were once used to selectively 
used for legacy/new tests. These annotations haven't been respected for a 
while, and the benefit is rather small.
    
    ## Verifying this change
    
    * green travis

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9176

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6005
    
----
commit 420b1dd124aff58bf85c0818c04167f3a6af9eab
Author: zentol <chesnay@...>
Date:   2018-05-14T08:18:48Z

    [FLINK-9176][tests] Remove category annotations

----


> Category annotations are unused
> -------------------------------
>
>                 Key: FLINK-9176
>                 URL: https://issues.apache.org/jira/browse/FLINK-9176
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System, Tests
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: mingleizhang
>            Priority: Critical
>             Fix For: 1.5.0
>
>
> The {{LegacyAndNew}} and {{New}} annotations, that were previously used to 
> disable tests based on whether the {{legacyCode}} profile is active, are 
> effectively unused.
> While several tests are annotated with them they are never used in the actual 
> {{surefire}} configuration.
> We should either re-introduce them into the {{surefire}} configuration, or 
> remove them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to