[ 
https://issues.apache.org/jira/browse/FLINK-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474391#comment-16474391
 ] 

ASF GitHub Bot commented on FLINK-9304:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5962#discussion_r188004528
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SystemProcessingTimeService.java
 ---
    @@ -197,6 +204,23 @@ public boolean shutdownAndAwaitPending(long time, 
TimeUnit timeUnit) throws Inte
                return timerService.awaitTermination(time, timeUnit);
        }
     
    +   @Override
    +   public boolean shutdownServiceUninterruptible(long timeoutMs) {
    --- End diff --
    
    Do we want to make the shutdown of the timer service swallow the 
`InterruptedException` also for all subsequent calls happening after the 
shutdown of the timer service?


> Timer service shutdown should not be interrupted
> ------------------------------------------------
>
>                 Key: FLINK-9304
>                 URL: https://issues.apache.org/jira/browse/FLINK-9304
>             Project: Flink
>          Issue Type: Bug
>          Components: Streaming
>    Affects Versions: 1.5.0, 1.4.2, 1.6.0
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>            Priority: Major
>
> Shutting down the timer service inĀ {{StreamTask::invoke}} can be interrupted 
> by the cancellation thread and make waiting for the shutdown exit prematurely.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to