[ 
https://issues.apache.org/jira/browse/FLINK-8989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475104#comment-16475104
 ] 

ASF GitHub Bot commented on FLINK-8989:
---------------------------------------

Github user zhangminglei commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5761#discussion_r188136030
  
    --- Diff: 
flink-end-to-end-tests/test-scripts/test_streaming_elasticsearch1.sh ---
    @@ -0,0 +1,66 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#     http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing, software
    +# distributed under the License is distributed on an "AS IS" BASIS,
    +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +# See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +# End to end test for ElasticsearchSink1.x.
    +
    +source "$(dirname "$0")"/common.sh
    +
    +start_cluster
    +
    +mkdir -p $TEST_DATA_DIR
    +
    
+ELASTICSEARCH_URL="https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-1.7.1.tar.gz";
    +echo "Downing Elasticsearch from $ELASTICSEARCH_URL"
    +curl "$ELASTICSEARCH_URL" > $TEST_DATA_DIR/elasticsearch.tar.gz
    +
    +tar xzf $TEST_DATA_DIR/elasticsearch.tar.gz -C $TEST_DATA_DIR/
    +ELASTICSEARCH_DIR=$TEST_DATA_DIR/elasticsearch-1.7.1
    +
    +# start elasticsearch cluster
    +$ELASTICSEARCH_DIR/bin/elasticsearch -daemon
    --- End diff --
    
    Will add verification for the elasticsearch process really start up.


> End-to-end test: ElasticSearch connector
> ----------------------------------------
>
>                 Key: FLINK-8989
>                 URL: https://issues.apache.org/jira/browse/FLINK-8989
>             Project: Flink
>          Issue Type: Sub-task
>          Components: ElasticSearch Connector, Tests
>            Reporter: Till Rohrmann
>            Assignee: mingleizhang
>            Priority: Major
>
> Similar to FLINK-8988 we should add a end-to-end test which tests the 
> {{ElasticSearch}} connector. We should run against all three supported 
> ElasticSearch versions: 1.x, 2.x and 5.x.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to