[
https://issues.apache.org/jira/browse/FLINK-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475245#comment-16475245
]
ASF GitHub Bot commented on FLINK-8933:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6014
[FLINK-8933] Avoid calling Class#newInstance
## What is the purpose of the change
*This pull request refactored the usage of `Class#newInstance`*
## Brief change log
- *Replaced `Class#newInstance` to
`Class#newInstance#getDeclaredConstructor#newInstance`*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / no / **don't know**)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8933
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6014
----
commit fa3e4dbb0f4adac31c3d30e67afd0d358def5e10
Author: yanghua <yanghua1127@...>
Date: 2018-05-15T03:11:06Z
[FLINK-8933] Avoid calling Class#newInstance
----
> Avoid calling Class#newInstance
> -------------------------------
>
> Key: FLINK-8933
> URL: https://issues.apache.org/jira/browse/FLINK-8933
> Project: Flink
> Issue Type: Task
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
>
> Class#newInstance is deprecated starting in Java 9 -
> https://bugs.openjdk.java.net/browse/JDK-6850612 - because it may throw
> undeclared checked exceptions.
> The suggested replacement is getDeclaredConstructor().newInstance(), which
> wraps the checked exceptions in InvocationException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
