Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5995#discussion_r188316643
  
    --- Diff: flink-formats/flink-avro-confluent-registry/pom.xml ---
    @@ -0,0 +1,94 @@
    +<?xml version="1.0" encoding="UTF-8"?>
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +  http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +-->
    +<project xmlns="http://maven.apache.org/POM/4.0.0";
    +            xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
    +            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
    +   <parent>
    +           <artifactId>flink-formats</artifactId>
    +           <groupId>org.apache.flink</groupId>
    +           <version>1.6-SNAPSHOT</version>
    +   </parent>
    +   <modelVersion>4.0.0</modelVersion>
    +
    +   <artifactId>flink-avro-confluent-registry</artifactId>
    +
    +   <repositories>
    +           <repository>
    +                   <id>confluent</id>
    +                   <url>http://packages.confluent.io/maven/</url>
    +           </repository>
    +   </repositories>
    +
    +   <dependencies>
    +           <dependency>
    +                   <groupId>io.confluent</groupId>
    +                   <artifactId>kafka-schema-registry-client</artifactId>
    +                   <version>3.3.1</version>
    +                   <exclusions>
    +                           <exclusion>
    +                                   <groupId>org.apache.avro</groupId>
    +                                   <artifactId>avro</artifactId>
    +                           </exclusion>
    +                           <exclusion>
    +                                   <groupId>org.slf4j</groupId>
    +                                   <artifactId>slf4j-log4j12</artifactId>
    +                           </exclusion>
    +                   </exclusions>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-core</artifactId>
    +                   <version>${project.version}</version>
    +                   <scope>provided</scope>
    +           </dependency>
    +           <dependency>
    +                   <groupId>org.apache.flink</groupId>
    +                   <artifactId>flink-avro</artifactId>
    +                   <version>${project.version}</version>
    +           </dependency>
    +   </dependencies>
    +
    +   <build>
    +           <plugins>
    +                   <plugin>
    +                           <groupId>org.apache.maven.plugins</groupId>
    +                           <artifactId>maven-shade-plugin</artifactId>
    +                           <executions>
    +                                   <execution>
    +                                           <id>shade-flink</id>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>shade</goal>
    +                                           </goals>
    +                                           <configuration>
    +                                                   <relocations 
combine.children="append">
    +                                                           <relocation>
    +                                                                   
<pattern>com.fasterxml.jackson.core</pattern>
    +                                                                   
<shadedPattern>org.apache.flink.shaded.com.fasterxml.jackson.core</shadedPattern>
    --- End diff --
    
    We may need to qualify this further by this project, because we have that 
relocation pattern already in other places, for potentially different jackson 
versions.


---

Reply via email to