ASF GitHub Bot commented on FLINK-9337:

Github user dawidwys commented on the issue:

    As for the snapshot binary data, I do understand that it should be created 
with appropriate flink version (in this case in theory with flink 1.3) and I've 
tried really hard to do so until I found out that this test is incompatible 
with 1.3 and the data could not be generated with flink 1.3 Later found out the 
comment to the test class that also states so: 
    > <p><b>Important:</b> Since Avro itself broke class compatibility between 
1.7.7 (used in Flink 1.3) 
    > * and 1.8.2 (used in Flink 1.4), the Avro by Pojo compatibility is broken 
through Avro already.
    > * This test only tests that the Avro serializer change (switching from 
Pojo to Avro for Avro types)
    > * works properly.
    Also the commented code does not compile with flink 1.3(but this is a minor 
    Data serialized with version of avro used in flink 1.3 (1.7.7) is not 
binary compatible with avro 1.8.2 (in flink 1.4+), due to changes how 
SpecificFixed is constructed.
    Therefore how I regenerated this snapshot data is that I run the commented 
code on current branch. That is why I also changed few descriptions to that 
test as it test compatibility of `PojoSerializer` with `AvroSerializer` rather 
than binary backwards compatibility. 
    Nevertheless I am more than happy to hear any comments on that. 

> Implement AvroDeserializationSchema
> -----------------------------------
>                 Key: FLINK-9337
>                 URL: https://issues.apache.org/jira/browse/FLINK-9337
>             Project: Flink
>          Issue Type: New Feature
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major

This message was sent by Atlassian JIRA

Reply via email to