[jira] [Commented] (FLINK-9354) print execution times for end-to-end tests

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/FLINK-9354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476866#comment-16476866
 ] 

ASF GitHub Bot commented on FLINK-9354:
---------------------------------------

Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6008#discussion_r188507930
  
    --- Diff: flink-end-to-end-tests/run-nightly-tests.sh ---
    @@ -43,121 +43,151 @@ EXIT_CODE=0
     #     printf 
"\n==============================================================================\n"
     #     printf "Running my fancy nightly end-to-end test\n"
     #     printf 
"==============================================================================\n"
    +#     start_timer
     #     $END_TO_END_DIR/test-scripts/test_something_very_fancy.sh
     #     EXIT_CODE=$?
    +#     end_timer
     # fi
     
     
     if [ $EXIT_CODE == 0 ]; then
         printf 
"\n==============================================================================\n"
         printf "Running HA end-to-end test\n"
         printf 
"==============================================================================\n"
    +    start_timer
         $END_TO_END_DIR/test-scripts/test_ha.sh
         EXIT_CODE=$?
    +    end_timer
     fi
     
     if [ $EXIT_CODE == 0 ]; then
       printf 
"\n==============================================================================\n"
       printf "Running Resuming Savepoint (file, async, no parallelism change) 
end-to-end test\n"
       printf 
"==============================================================================\n"
    +  start_timer
       STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
       EXIT_CODE=$?
    +  end_timer
     fi
     
     if [ $EXIT_CODE == 0 ]; then
       printf 
"\n==============================================================================\n"
       printf "Running Resuming Savepoint (file, sync, no parallelism change) 
end-to-end test\n"
       printf 
"==============================================================================\n"
    +  start_timer
       STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=false 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 2
       EXIT_CODE=$?
    +  end_timer
     fi
     
     if [ $EXIT_CODE == 0 ]; then
       printf 
"\n==============================================================================\n"
       printf "Running Resuming Savepoint (file, async, scale up) end-to-end 
test\n"
       printf 
"==============================================================================\n"
    +  start_timer
       STATE_BACKEND_TYPE=file STATE_BACKEND_FILE_ASYNC=true 
$END_TO_END_DIR/test-scripts/test_resume_savepoint.sh 2 4
       EXIT_CODE=$?
    +  end_timer
     fi
    --- End diff --
    
    Perhaps we can refactor this whole block into a common base script for the 
nightly / pre-commit hook scripts.
    The end_timer / start_timer functions should also be located there.


> print execution times for end-to-end tests
> ------------------------------------------
>
>                 Key: FLINK-9354
>                 URL: https://issues.apache.org/jira/browse/FLINK-9354
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests, Travis
>    Affects Versions: 1.5.0
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We need to modify the end-to-end scripts to include the time it takes for a 
> test to run.
> We currently don't have any clue how long a test actually runs for.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)