[ 
https://issues.apache.org/jira/browse/FLINK-2391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14636776#comment-14636776
 ] 

ASF GitHub Bot commented on FLINK-2391:
---------------------------------------

Github user mjsax commented on a diff in the pull request:

    https://github.com/apache/flink/pull/932#discussion_r35205049
  
    --- Diff: 
flink-contrib/flink-storm-compatibility/flink-storm-compatibility-core/src/main/java/org/apache/flink/stormcompatibility/api/FlinkTopologyBuilder.java
 ---
    @@ -138,6 +138,21 @@ public FlinkTopology createTopology() {
                                        DataStream<?> inputDataStream = 
availableOperators.get(producerId);
     
                                        if (inputDataStream != null) {
    +                                           // get upstream operator
    --- End diff --
    
    Move this code with the `if (grouping.is_set_fields())` then-Block (line 
161). Introduce local variable and look up declarer in introduced HashMap: 
`FlinkOutputFieldsDeclarer d = this.declarers.get(producerId)`


> Storm-compatibility:method FlinkTopologyBuilder.createTopology() throws 
> java.lang.NullPointerException
> ------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-2391
>                 URL: https://issues.apache.org/jira/browse/FLINK-2391
>             Project: Flink
>          Issue Type: Bug
>          Components: flink-contrib
>    Affects Versions: 0.10
>         Environment: win7 32bit;linux
>            Reporter: Huang Wei
>              Labels: features
>             Fix For: 0.10
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> core dumped at FlinkOutputFieldsDeclarer.java : 160(package 
> FlinkOutputFieldsDeclarer).
> code : fieldIndexes[i] = this.outputSchema.fieldIndex(groupingFields.get(i));
> in this line, the var this.outputSchema may be null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to