[ 
https://issues.apache.org/jira/browse/FLINK-9299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476987#comment-16476987
 ] 

ASF GitHub Bot commented on FLINK-9299:
---------------------------------------

Github user yanghua commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6001#discussion_r188530473
  
    --- Diff: docs/dev/stream/operators/windows.md ---
    @@ -797,7 +797,7 @@ DataStream<SensorReading> input = ...;
     
     input
       .keyBy(<key selector>)
    -  .timeWindow(<window assigner>)
    +  .timeWindow(<time size>)
    --- End diff --
    
    accept, hold on...


> ProcessWindowFunction documentation Java examples have errors
> -------------------------------------------------------------
>
>                 Key: FLINK-9299
>                 URL: https://issues.apache.org/jira/browse/FLINK-9299
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>    Affects Versions: 1.4.2
>            Reporter: Ken Krugler
>            Assignee: vinoyang
>            Priority: Minor
>
> In looking at 
> [https://ci.apache.org/projects/flink/flink-docs-release-1.4/dev/stream/operators/windows.html#processwindowfunction-with-incremental-aggregation],
>  I noticed a few errors...
>  * "This allows to incrementally compute windows" should be "This allows it 
> to incrementally compute windows"
>  * DataStream<Tuple2<String, Long> input = ...; should be 
> DataStream<Tuple2<String, Long>> input = ...;
>  * The getResult() method needs to cast one of the accumulator values to a 
> double, if that's what it is going to return.
>  * MyProcessWindowFunction needs to extend, not implement 
> ProcessWindowFunction
>  * MyProcessWindowFunction needs to implement a process() method, not an 
> apply() method.
>  * The call to .timeWindow takes a Time parameter, not a window assigner.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to