Github user sijie commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5845#discussion_r188867505
  
    --- Diff: 
flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/streaming/connectors/pulsar/PulsarProduceMode.java
 ---
    @@ -0,0 +1,36 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.pulsar;
    +
    +/**
    + * The supported producing modes of operation for flink's pulsar producer.
    + */
    +public enum PulsarProduceMode {
    +
    +   /**
    +    * Any produce failures will be ignored hence there could be data loss.
    +    */
    +   AT_MOST_ONCE,
    +
    +   /**
    +    * The producer will ensure that all the events are persisted in pulsar.
    +    * There could be duplicate events written though.
    +    */
    +   AT_LEAST_ONE,
    --- End diff --
    
    nice catch. It should be `AT_LEAST_ONCE`


---

Reply via email to