[ 
https://issues.apache.org/jira/browse/FLINK-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479515#comment-16479515
 ] 

ASF GitHub Bot commented on FLINK-8655:
---------------------------------------

Github user ctamisier commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5964#discussion_r189056714
  
    --- Diff: 
flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java
 ---
    @@ -429,6 +429,26 @@ public void testCassandraPojoAtLeastOnceSink() throws 
Exception {
                Assert.assertEquals(20, rs.all().size());
        }
     
    +   @Test
    +   public void testCassandraPojoNoAnnotatedKeyspaceAtLeastOnceSink() 
throws Exception {
    --- End diff --
    
    Resolved. It was used in CassandraPojoSinkBuilder.createSink(),


> Add a default keyspace to CassandraSink
> ---------------------------------------
>
>                 Key: FLINK-8655
>                 URL: https://issues.apache.org/jira/browse/FLINK-8655
>             Project: Flink
>          Issue Type: Improvement
>          Components: Cassandra Connector
>    Affects Versions: 1.4.0
>            Reporter: Christopher Hughes
>            Priority: Minor
>              Labels: features
>             Fix For: 1.6.0
>
>
> Currently, to use the CassandraPojoSink, it is necessary for a user to 
> provide keyspace information on the desired POJOs using datastax annotations. 
>  This allows various POJOs to be written to multiple keyspaces while sinking 
> messages, but prevent runtime flexibility.
> For many developers, non-production environments may all share a single 
> Cassandra instance differentiated by keyspace names.  I propose adding a 
> `defaultKeyspace(String keyspace)` to the ClusterBuilder.  POJOs lacking a 
> definitive keyspace would attempt to be loaded to the provided default.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to