[GitHub] flink pull request #5619: [FLINK-8838] [table] Add Support for UNNEST a Mult...

[suez1224]

Github user suez1224 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5619#discussion_r189145367
  
    --- Diff: 
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/AggregateITCase.scala
 ---
    @@ -367,6 +367,36 @@ class AggregateITCase(
         TestBaseUtils.compareResultAsText(result.asJava, expected)
       }
     
    +  @Test
    +  def testTumbleWindowAggregateWithCollectUnnest(): Unit = {
    --- End diff --
    
    Can we just not use COLLECT to construct the test samples? In general, a 
unittest should test one thing a time, not multiple. And also for the streaming 
case.


---