Github user tzulitai commented on a diff in the pull request:
    --- Diff: 
    @@ -218,6 +232,8 @@ public void invoke(OUT value, Context context) throws 
Exception {
                        throw new RuntimeException("Kinesis producer has been 
    +           checkAndPropagateAsyncError();
    +           checkQueueLimit();
    --- End diff --
    This second check is to check any async errors that occurred during the 
queue flush, correct?
    If so, we should probably move this second invocation into 
`checkQueueLimit` to make this more implicit.


Reply via email to