[
https://issues.apache.org/jira/browse/FLINK-9402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483640#comment-16483640
]
ASF GitHub Bot commented on FLINK-9402:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6045#discussion_r189815405
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -244,7 +244,11 @@ public static void validateAwsConfiguration(Properties
config) {
}
if (!config.containsKey(AWSConfigConstants.AWS_REGION)) {
- throw new IllegalArgumentException("The AWS region ('"
+ AWSConfigConstants.AWS_REGION + "') must be set in the config.");
+ if
(!config.containsKey(ConsumerConfigConstants.AWS_ENDPOINT)) {
+ // per validation in AwsClientBuilder
+ throw new
IllegalArgumentException(String.format("Either AWS region ('%s') or AWS
endpoint ('%s') must be set in the config.",
+ AWSConfigConstants.AWS_REGION,
AWSConfigConstants.AWS_REGION));
+ }
} else {
--- End diff --
Do we also need to check that not both `AWS_REGION` and `AWS_ENDPOINT` is
set?
(Since the AwsClientBuilder says that ONLY ONE of these 2 may be set).
> Kinesis consumer validation incorrectly requires aws.region property
> --------------------------------------------------------------------
>
> Key: FLINK-9402
> URL: https://issues.apache.org/jira/browse/FLINK-9402
> Project: Flink
> Issue Type: Bug
> Components: Kinesis Connector
> Affects Versions: 1.5.0
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Minor
>
> AwsClientBuilder says: Only one of Region or EndpointConfiguration may be set.
> But KinesisUtil still thinks: The AWS region ('aws.region') must be set in
> the config.
> This doesn't affect configuration based on region, but makes testing with
> Kinesalite impossible. The Flink code needs to match the new opinion in AWS
> SDK (probably changed with . recent update).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
