[
https://issues.apache.org/jira/browse/FLINK-7814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483929#comment-16483929
]
ASF GitHub Bot commented on FLINK-7814:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/6027#discussion_r189895031
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/ExpressionParser.scala
---
@@ -210,6 +212,14 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
case agg ~ _ ~ windowRef => UnresolvedOverCall(agg, windowRef)
}
+ lazy val between: PackratParser[Expression] =
+ expression ~ "." ~ (BETWEEN | NOT_BETWEEN) ~ "(" ~ expression ~ "," ~
expression ~ ")" ^^ {
--- End diff --
The changes in `ExpressionParser` should not be necessary if you add the
expression classes to `org.apache.flink.table.validate.FunctionCatalog`. What
happens if you remove these changes?
> Add BETWEEN and NOT BETWEEN expression to Table API
> ---------------------------------------------------
>
> Key: FLINK-7814
> URL: https://issues.apache.org/jira/browse/FLINK-7814
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.4.0
> Reporter: Fabian Hueske
> Assignee: Ruidong Li
> Priority: Minor
>
> * The Table API does not have a BETWEEN expression. BETWEEN is quite handy
> when defining join predicates for window joins.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
