[
https://issues.apache.org/jira/browse/FLINK-8511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483975#comment-16483975
]
ASF GitHub Bot commented on FLINK-8511:
---------------------------------------
GitHub user kisimple opened a pull request:
https://github.com/apache/flink/pull/6055
[FLINK-8511][table] Remove legacy code for the TableType annotation
## What is the purpose of the change
TableSource factories had already been used to unify the definition of
table sources, the old `TableType` code paths can be removed safely.
## Brief change log
- Delete
TableType.java/TableSourceConverter.java/CsvTableSourceConverter.java/tableSourceConverter.properties
- Delete
`NoMatchedTableSourceConverterException`/`AmbiguousTableSourceConverterException`
- Delete ExternalTableSourceUtilTest.java cause it only test the
`TableType` code paths
- Drop the org.reflections and commons-configuration dependencies
- Remove legacy code in ExternalCatalogTable.scala and
ExternalTableSourceUtil.scala
- Update CommonTestData.scala/InMemoryExternalCatalogTest.scala to adapt
with `ExternalCatalogTable`
- Update ExternalCatalogSchemaTest.scala to adapt with
`ExternalTableSourceUtil`
## Verifying this change
This change is already covered by existing tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kisimple/flink FLINK-8511
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6055.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6055
----
commit 719930a590d6fec26117253d2f0a19b4a1a1a54d
Author: blueszheng <kisimple@...>
Date: 2018-05-22T12:52:35Z
[FLINK-8511][table] Remove legacy code for the TableType annotation
----
> Remove legacy code for the TableType annotation
> -----------------------------------------------
>
> Key: FLINK-8511
> URL: https://issues.apache.org/jira/browse/FLINK-8511
> Project: Flink
> Issue Type: Improvement
> Components: Table API & SQL
> Affects Versions: 1.6.0
> Reporter: Timo Walther
> Assignee: blues zheng
> Priority: Critical
>
> We introduced the very generic TableSource factories that unify the
> definition of table sources and are specified using Java service loaders. For
> backwards compatibility, the old code paths are still supported but should be
> dropped in future Flink versions.
> This will touch:
> {code}
> org.apache.flink.table.annotation.TableType
> org.apache.flink.table.catalog.ExternalCatalogTable
> org.apache.flink.table.api.NoMatchedTableSourceConverterException
> org.apache.flink.table.api.AmbiguousTableSourceConverterException
> org.apache.flink.table.catalog.TableSourceConverter
> org.apache.flink.table.catalog.ExternalTableSourceUtil
> {code}
> We can also drop the {{org.reflections}} and {{commons-configuration}} (and
> maybe more?) dependencies.
> See also FLINK-8240
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
