Github user yanghua commented on a diff in the pull request:
https://github.com/apache/flink/pull/6028#discussion_r189943667
--- Diff:
flink-queryable-state/flink-queryable-state-runtime/src/main/java/org/apache/flink/queryablestate/client/proxy/KvStateClientProxyHandler.java
---
@@ -225,7 +225,9 @@ private void executeActionAsync(
return location;
} else {
- return FutureUtils.completedExceptionally(new
UnknownLocationException("Could not contact the state location oracle to
retrieve the state location."));
+ return FutureUtils.completedExceptionally(
+ new UnknownLocationException("Could not contact
the state location oracle to retrieve the state location for state="
+ + queryableStateName + " of job=" +
jobId + ", the caused reason maybe the state is not ready or there is no job
exists."));
--- End diff --
@florianschmidt1994 thanks for your opinion
for 1 : here the thrown error message is based on
` final KvStateLocationOracle kvStateLocationOracle =
proxy.getKvStateLocationOracle(jobId);
`
if `kvStateLocationOracle` is null will throw the exception, but just
depends this variable, we could not give a explicit reason, I think giving the
possibility is good, the explicit reason should been given in the
implementation of method `getKvStateLocationOracle` or others (but not belongs
this issue).
for 2 : accept your idea, we cold remove the **oracle** keyword
---
