[
https://issues.apache.org/jira/browse/FLINK-9257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16486732#comment-16486732
]
ASF GitHub Bot commented on FLINK-9257:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r190126071
--- Diff:
flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh ---
@@ -53,8 +53,6 @@ function cleanup_after_test {
#
kill ${watchdog_pid} 2> /dev/null
wait ${watchdog_pid} 2> /dev/null
- #
- cleanup
--- End diff --
The `test_local_recovery_and_scheduling` test currently bundles several
executions of the test (e.g. with different state backend configurations) in a
single run of the test script. That's why it required this cleanup within the
test itself.
How would the change of this PR affect this?
In general, should we also restructure e2e tests so that each execution
configuration variant should be executed with the
`test-runner-cleanup#run_test` method (instead of cleaning up itself in-between
executions)?
AFAIK, only the `test_local_recovery_and_scheduling` does this at the
moment.
> End-to-end tests prints "All tests PASS" even if individual test-script
> returns non-zero exit code
> --------------------------------------------------------------------------------------------------
>
> Key: FLINK-9257
> URL: https://issues.apache.org/jira/browse/FLINK-9257
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Florian Schmidt
> Assignee: Florian Schmidt
> Priority: Critical
> Fix For: 1.5.0
>
>
> In some cases the test-suite exits with non-zero exit code but still prints
> "All tests PASS" to stdout. This happens because how the test runner works,
> which is roughly as follows
> # Either run-nightly-tests.sh or run-precommit-tests.sh executes a suite of
> tests consisting of one multiple bash scripts.
> # As soon as one of those bash scripts exists with non-zero exit code, the
> tests won't continue to run and the test-suite will also exit with non-zero
> exit code.
> # *During the cleanup hook (trap cleanup EXIT in common.sh) it will be
> checked whether there are non-empty out files or log files with certain
> exceptions. If a tests fails with non-zero exit code, but does not have any
> exceptions or .out files, this will still print "All tests PASS" to stdout,
> even though they don't*
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
