Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/6053#discussion_r190126071
--- Diff:
flink-end-to-end-tests/test-scripts/test_local_recovery_and_scheduling.sh ---
@@ -53,8 +53,6 @@ function cleanup_after_test {
#
kill ${watchdog_pid} 2> /dev/null
wait ${watchdog_pid} 2> /dev/null
- #
- cleanup
--- End diff --
The `test_local_recovery_and_scheduling` test currently bundles several
executions of the test (e.g. with different state backend configurations) in a
single run of the test script. That's why it required this cleanup within the
test itself.
How would the change of this PR affect this?
In general, should we also restructure e2e tests so that each execution
configuration variant should be executed with the
`test-runner-cleanup#run_test` method (instead of cleaning up itself in-between
executions)?
AFAIK, only the `test_local_recovery_and_scheduling` does this at the
moment.
---
