[
https://issues.apache.org/jira/browse/FLINK-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487279#comment-16487279
]
ASF GitHub Bot commented on FLINK-9426:
---------------------------------------
GitHub user sihuazhou opened a pull request:
https://github.com/apache/flink/pull/6063
[FLINK-9426][test] Harden RocksDBWriteBatchPerformanceTest.benchMark()
## What is the purpose of the change
We use the assert to check the performance of WriteBatch is better than
Put(), this should be true in general, but in sometimes this could also be
false. We may need to follow the other tests under the
`org.apache.flink.contrib.streaming.state.benchmark.*`, only use the timeout
property to guard the tests.
## Brief change log
- remove asserts from RocksDBWriteBatchPerformanceTest.benchMark()
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sihuazhou/flink FLINK-9426
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6063.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6063
----
commit 167289827e75a150689abed84784b2c5685b9ed0
Author: sihuazhou <summerleafs@...>
Date: 2018-05-23T13:47:41Z
remove asserts from RocksDBWriteBatchPerformanceTest.benchMark()
----
> Harden RocksDBWriteBatchPerformanceTest.benchMark()
> ---------------------------------------------------
>
> Key: FLINK-9426
> URL: https://issues.apache.org/jira/browse/FLINK-9426
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.6.0, 1.5.1
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
> Fix For: 1.6.0
>
>
> We use the assert to check the performance of WriteBatch is better than
> Put(), this should be true in general, but in sometimes this could also be
> false. We may need to follow the other tests under the
> *org.apache.flink.contrib.streaming.state.benchmark.**, only use the timeout
> property to valid the test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
