Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/6031
Thanks for the review and manual checks! I either addressed your comments
in fixup commit and left comment responses otherwise.
> Do we file a follow up ticket to remove netty-router from our shaded
Netty? Optionally, we might consider adding an import suppression for
org.apache.flink.shaded.netty4.io.netty.handler.codec.http.router.* to guard
against any accidental usage until we remove the dependency.
I planned to upgrade netty and drop netty-router in one step of upgrading
`flink-shaded-netty`. Do you think it should be split somehow?
> I don't know what your opinion is on cleaning up the copied classes. I'm
OK with keeping everything as is, but I get a bunch of minor/trivial warnings
about the code (like code visibility, unchecked calls, unused variables, etc.).
I understand if we want to stay close to the copied classes.
I would be open to clean it up as we think it's best. I do not see a point
in maintaining compatibility with the original sources. If you have other such
comments, please feel free to write them.
---
