Github user EAlexRojas commented on a diff in the pull request:
https://github.com/apache/flink/pull/5991#discussion_r190518142
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/internal/KafkaConsumerThread.java
---
@@ -80,6 +83,9 @@
/** The queue of unassigned partitions that we need to assign to the
Kafka consumer. */
private final
ClosableBlockingQueue<KafkaTopicPartitionState<TopicPartition>>
unassignedPartitionsQueue;
+ /** The list of partitions to be removed from kafka consumer. */
+ private final Set<TopicPartition> partitionsToBeRemoved;
--- End diff --
From my understanding, for unassigned partitions we can use a Queue because
it does not matter which consumer will take the new partitions.
But we can not use a Queue for partitions to be removed because we only can
remove the partitions from the consumer that is actually subscribed to that
partition.
Does that make sense ?
---