[GitHub] flink pull request #6069: [FLINK-9416] Make all RestClusterClient calls retr...

[GJL]

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6069#discussion_r190605113
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
 ---
    @@ -274,11 +275,17 @@ public JobSubmissionResult submitJob(JobGraph 
jobGraph, ClassLoader classLoader)
                final JobMessageParameters  params = new JobMessageParameters();
                params.jobPathParameter.resolve(jobId);
     
    -           CompletableFuture<JobDetailsInfo> responseFuture = 
sendRequest(detailsHeaders, params);
    +           CompletableFuture<JobDetailsInfo> responseFuture = sendRequest(
    +                   detailsHeaders,
    +                   params);
     
                return responseFuture.thenApply(JobDetailsInfo::getJobStatus);
        }
     
    +   private Predicate<Throwable> isConnectionProblemOrServiceUnavailable() {
    --- End diff --
    
    nit: can be `static` and defined closer to `isConnectionProblemException` 
and `isServiceUnavailable`


---