[
https://issues.apache.org/jira/browse/FLINK-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640736#comment-14640736
]
ASF GitHub Bot commented on FLINK-2231:
---------------------------------------
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/935
[FLINK-2231] Create a Serializer for Scala Enumerations.
This closes FLINK-2231.
The code should work for all objects which follow [the Enumeration idiom
outlined in the
ScalaDoc](http://www.scala-lang.org/api/2.11.5/index.html#scala.Enumeration).
The second commit removes the boilerplate code from the
`EnumValueComparator` by delegating to an `IntComparator`, you can either
discard or squash it while merging depending on your preference.
Bear in mind the FIXME at line 368 in `TypeAnalyzer.scala`. The commented
code is better, but unfortunately doesn't work with Scala 2.10, so I used the
FQN workaround.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aalexandrov/flink FLINK-2231
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/935.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #935
----
commit fd69bda383f6771e87ded1b4b595a395519efd6e
Author: Alexander Alexandrov <[email protected]>
Date: 2015-07-24T10:36:17Z
[FLINK-2231] Create a Serializer for Scala Enumerations.
commit dca03720d090c383f88a57af6808fdbfd2c4ec29
Author: Alexander Alexandrov <[email protected]>
Date: 2015-07-24T16:43:14Z
Delegating EnumValueComparator.
----
> Create a Serializer for Scala Enumerations
> ------------------------------------------
>
> Key: FLINK-2231
> URL: https://issues.apache.org/jira/browse/FLINK-2231
> Project: Flink
> Issue Type: Improvement
> Components: Scala API
> Reporter: Stephan Ewen
> Assignee: Alexander Alexandrov
>
> Scala Enumerations are currently serialized with Kryo, but should be
> efficiently serialized by just writing the {{initial}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
