[ 
https://issues.apache.org/jira/browse/FLINK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490675#comment-16490675
 ] 

ASF GitHub Bot commented on FLINK-3952:
---------------------------------------

Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6071#discussion_r190884312
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestClient.java ---
    @@ -247,7 +249,15 @@ public void shutdown(Time timeout) {
     
                @Override
                protected void channelRead0(ChannelHandlerContext ctx, Object 
msg) {
    -                   if (msg instanceof FullHttpResponse) {
    +                   // TODO: should this check for status OK (200) and 
treat all other as errors?
    --- End diff --
    
    Thx for filling this out. In that case should I just drop this `// TODO:`?


> Bump Netty to 4.1
> -----------------
>
>                 Key: FLINK-3952
>                 URL: https://issues.apache.org/jira/browse/FLINK-3952
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core, Network
>            Reporter: rektide de la fey
>            Assignee: Piotr Nowojski
>            Priority: Major
>              Labels: netty
>
> Netty 4.1 is about to release final. This release has [a number of 
> significant 
> enhancements|http://netty.io/wiki/new-and-noteworthy-in-4.1.html], and in 
> particular I find HTTP/2 codecs to be incredibly desirable to have. 
> Additionally, hopefully, the [Hadoop patches for Netty 
> 4.1|https://issues.apache.org/jira/browse/HADOOP-11716] get some tests and 
> get merged, & I believe if/when that happens it'll be important for Flink to 
> also be using the new Netty minor version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to