[
https://issues.apache.org/jira/browse/FLINK-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16491612#comment-16491612
]
ASF GitHub Bot commented on FLINK-8067:
---------------------------------------
GitHub user yanghua opened a pull request:
https://github.com/apache/flink/pull/6081
[FLINK-8067] User code ClassLoader not set before calling
ProcessingTimeCallback
## What is the purpose of the change
*This pull request sets the user code class loader for the thread factory*
## Brief change log
- *Sets the user code class loader for the thread factory*
## Verifying this change
This change is already covered by existing tests*.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes /
**no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs /
JavaDocs / **not documented**)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yanghua/flink FLINK-8067
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6081.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6081
----
commit 2f11cabedc62ceded05a2ef02b88abfc79a77ba1
Author: yanghua <yanghua1127@...>
Date: 2018-05-26T10:44:21Z
[FLINK-8067] User code ClassLoader not set before calling
ProcessingTimeCallback
----
> User code ClassLoader not set before calling ProcessingTimeCallback
> -------------------------------------------------------------------
>
> Key: FLINK-8067
> URL: https://issues.apache.org/jira/browse/FLINK-8067
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.4.0
> Reporter: Gary Yao
> Assignee: vinoyang
> Priority: Minor
> Fix For: 1.5.1
>
>
> The user code ClassLoader is not set as the context ClassLoader for the
> thread invoking {{ProcessingTimeCallback#onProcessingTime(long timestamp)}}:
> https://github.com/apache/flink/blob/84a07a34ac22af14f2dd0319447ca5f45de6d0bb/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java#L222
> This is problematic, for example, if user code dynamically loads classes in
> {{ProcessFunction#onTimer(long timestamp, OnTimerContext ctx, Collector<O>
> out)}} using the current thread's context ClassLoader (also see FLINK-8005).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
