Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5846#discussion_r191150742
  
    --- Diff: 
flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java 
---
    @@ -896,6 +898,10 @@ public static JobGraph getJobGraph(Configuration 
flinkConfig, FlinkPlan optPlan,
                        job = gen.compileJobGraph((OptimizedPlan) optPlan);
                }
     
    +           //  if we disable checkpoint and do not set restart strategy, 
Restart strategy will be set as in flink-conf.yaml
    +           //  in flip6, jobmaster do not set this conf, so we have set 
this conf here.
    --- End diff --
    
    I am pretty sure the behaviour is still there. In JobMaster.java, or am I 
wrong?
    
        final RestartStrategies.RestartStrategyConfiguration 
restartStrategyConfiguration =
                        jobGraph.getSerializedExecutionConfig()
                                        .deserializeValue(userCodeLoader)
                                        .getRestartStrategy();
    
        this.restartStrategy = (restartStrategyConfiguration != null) ?
                        
RestartStrategyFactory.createRestartStrategy(restartStrategyConfiguration) :
                        
jobManagerSharedServices.getRestartStrategyFactory().createRestartStrategy();


---

Reply via email to