Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6087#discussion_r191162395
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -510,4 +509,39 @@ private int generatePriority(ResourceProfile 
resourceProfile) {
                }
        }
     
    +   /**
    +    * Implements NMClientAsyncCallbackHandler.
    +    */
    +   private class NMClientAsyncCallbackHandler implements 
NMClientAsync.CallbackHandler {
    --- End diff --
    
    Maybe we could let YarnResourceManager to implement this interface, as it 
has implemented the `AMRMClientAsync.CallbackHandler`.


---

Reply via email to