[
https://issues.apache.org/jira/browse/FLINK-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492716#comment-16492716
]
ASF GitHub Bot commented on FLINK-6469:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/5448#discussion_r191198882
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerServices.java
---
@@ -647,7 +649,16 @@ public static long calculateHeapSizeMB(long
totalJavaMemorySizeMB, Configuration
final long heapSizeMB;
if (useOffHeap) {
- long offHeapSize =
config.getLong(TaskManagerOptions.MANAGED_MEMORY_SIZE);
+ String managedMemorySizeDefaultVal =
TaskManagerOptions.MANAGED_MEMORY_SIZE.defaultValue();
+ long offHeapSize = 0;
+ try {
+ offHeapSize =
Long.valueOf(managedMemorySizeDefaultVal);
+ if
(!config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE).equals(managedMemorySizeDefaultVal))
{
+ offHeapSize =
MemorySize.parse(config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE)).getMebiBytes();
+ }
+ } catch (IllegalArgumentException e) {
+
--- End diff --
I found the flow with default value somewhat counterintuitive. How about we
structure this code like this:
long offHeapSize;
String managedMemorySizeDefaultVal =
TaskManagerOptions.MANAGED_MEMORY_SIZE.defaultValue();
if
(!config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE).equals(managedMemorySizeDefaultVal))
{
try {
offHeapSize =
MemorySize.parse(config.getString(TaskManagerOptions.MANAGED_MEMORY_SIZE))
.getMebiBytes();
} catch (IllegalArgumentException e) {
throw new IllegalConfigurationException(
"Could not read " +
TaskManagerOptions.MANAGED_MEMORY_SIZE.key(), e);
}
} else {
offHeapSize = Long.valueOf(managedMemorySizeDefaultVal);
}
> Configure Memory Sizes with units
> ---------------------------------
>
> Key: FLINK-6469
> URL: https://issues.apache.org/jira/browse/FLINK-6469
> Project: Flink
> Issue Type: Improvement
> Components: Core
> Reporter: Stephan Ewen
> Assignee: vinoyang
> Priority: Major
>
> Currently, memory sizes are configured by pure numbers, the interpretation is
> different from configuration parameter to parameter.
> For example, heap sizes are configured in megabytes, network buffer memory is
> configured in bytes, alignment thresholds are configured in bytes.
> I propose to configure all memory parameters the same way, with units similar
> to time. The JVM itself configured heap size similarly: {{Xmx5g}} or
> {{Xmx2000m}}.
> {code}
> 10000 -> bytes
> 10 kb
> 64 mb
> 1 gb
> ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
