Github user medcv commented on the issue:

    https://github.com/apache/flink/pull/6089
  
    @zentol Thanks for review!
    Yes, I totally agree as the most of test script is duplicated, we need to 
refactor them the way you mentioned, I will update the PR with new changes.
    
    QQ: One reason I borrowed an example from 'Flink-example' module was to e2e 
test the actual example code also.  One benefit would be testing the actual 
example and safeguard the 'Flink-example' module from any code changes without 
passing the tests. (or another cleaner option is to increase unittest coverage 
to flink-example package).
    Do you think we should have a dedicated module under test folder or extend 
the 'Flink-example' module with ES example and test e2e for that.


---

Reply via email to