[
https://issues.apache.org/jira/browse/FLINK-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493550#comment-16493550
]
ASF GitHub Bot commented on FLINK-9451:
---------------------------------------
Github user medcv commented on the issue:
https://github.com/apache/flink/pull/6089
@zentol Thanks for review!
Yes, I totally agree as the most of test script is duplicated, we need to
refactor them the way you mentioned, I will update the PR with new changes.
QQ: One reason I borrowed an example from 'Flink-example' module was to e2e
test the actual example code also. One benefit would be testing the actual
example and safeguard the 'Flink-example' module from any code changes without
passing the tests. (or another cleaner option is to increase unittest coverage
to flink-example package).
Do you think we should have a dedicated module under test folder or extend
the 'Flink-example' module with ES example and test e2e for that.
> End-to-end test: Scala Quickstarts
> ----------------------------------
>
> Key: FLINK-9451
> URL: https://issues.apache.org/jira/browse/FLINK-9451
> Project: Flink
> Issue Type: Sub-task
> Components: Quickstarts
> Affects Versions: 1.5.0, 1.4.1, 1.4.2
> Reporter: Yazdan Shirvany
> Assignee: Yazdan Shirvany
> Priority: Blocker
>
> We could add an end-to-end test which verifies Flink's quickstarts scala. It
> should do the following:
> # create a new Flink project using the quickstarts archetype
> # add a new Flink dependency to the {{pom.xml}} (e.g. Flink connector or
> library)
> # run {{mvn clean package -Pbuild-jar}}
> # verify that no core dependencies are contained in the jar file
> # Run the program
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
