[
https://issues.apache.org/jira/browse/FLINK-9440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16493563#comment-16493563
]
ASF GitHub Bot commented on FLINK-9440:
---------------------------------------
GitHub user StefanRRichter opened a pull request:
https://github.com/apache/flink/pull/6096
[FLINK-9440][streaming] Expose cancelation of timers through timer service
interface
## What is the purpose of the change
This PR is enhancing PR #6077 and #6062. The purpose is to expose timer
cancelation that has been optimized in the previously mentioned PRs to the user.
## Brief change log
Introduced `TimerService::deleteProcessingTimeTimer(long)` and
`TimerService::deleteEventTimeTimer(long)`.
## Verifying this change
Existing tests in `KeyedProcessOperatorTest` and
`KeyedCoProcessOperatorTest` have been enhanced to cover the new functionality.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: no)
## Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (JavaDocs)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StefanRRichter/flink expose-timer-delete
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/6096.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #6096
----
commit fffc7ff6750509de2c97ea7ed44d2404669acd35
Author: Stefan Richter <s.richter@...>
Date: 2018-05-08T14:00:55Z
[FLINK-9423][state] Implement efficient deletes for heap-based timer
service.
commit a8e0f2f6bf4343938819e2e9a3b7ea29e94d0fc0
Author: Stefan Richter <s.richter@...>
Date: 2018-05-23T15:39:47Z
review comments
commit 4fc37152905f80ba2c6db2d0fdc08273a751c34b
Author: Stefan Richter <s.richter@...>
Date: 2018-05-24T13:08:02Z
[FLINK-9436][state] Remove generic parameter namespace from
InternalTimeServiceManager.
commit 3813ffd4eafb3884b6c0d7aa7f4aa155c943fb68
Author: Stefan Richter <s.richter@...>
Date: 2018-05-28T14:52:53Z
[FLINK-9440][streaming] Expose cancelation of timers through timer service
interface.
----
> Allow cancelation and reset of timers
> -------------------------------------
>
> Key: FLINK-9440
> URL: https://issues.apache.org/jira/browse/FLINK-9440
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 1.4.2
> Reporter: Elias Levy
> Assignee: Stefan Richter
> Priority: Major
>
> Currently the {{TimerService}} allows one to register timers, but it is not
> possible to delete a timer or to reset a timer to a new value. If one wishes
> to reset a timer, one must also handle the previous inserted timer callbacks
> and ignore them.
> I would be useful if the API allowed one to remove and reset timers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
