Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/6062#discussion_r191445752
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/InternalTimersSnapshotReaderWriters.java
---
@@ -96,7 +96,7 @@ public
AbstractInternalTimersSnapshotWriter(InternalTimersSnapshot<K, N> timersS
public final void writeTimersSnapshot(DataOutputView out)
throws IOException {
writeKeyAndNamespaceSerializers(out);
- InternalTimer.TimerSerializer<K, N> timerSerializer =
new InternalTimer.TimerSerializer<>(
+ TimerHeapInternalTimer.TimerSerializer<K, N>
timerSerializer = new TimerHeapInternalTimer.TimerSerializer<>(
--- End diff --
Isn't this a bit problematic if we add a new `TimerService` implementation
other than the `HeapInternalTimerService`? The `InternalTimersSnapshot` is
independent of the underlying timer service implementation and so should the
timer serializer be.
---
