Github user sihuazhou commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5582#discussion_r191453657
  
    --- Diff: 
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeySerializationUtils.java
 ---
    @@ -138,4 +138,12 @@ private static void writeVariableIntBytes(
                        value >>>= 8;
                } while (value != 0);
        }
    +
    +   public static byte[] serializeKeyGroup(int keyGroup, int 
keyGroupPrefixBytes) {
    +           byte[] startKeyGroupPrefixBytes = new byte[keyGroupPrefixBytes];
    --- End diff --
    
    Some info about the experiment I did: 
    
    - I set `ReadOptions::ignore_range_deletions = true` to speed up the read 
performance, because we won't read any records that belong to the key-group we 
have deleted. 
    - I only call the `deleteRange()` twice, because we will at most call it 
twice in the recovery of the incremental checkpoint.


---

Reply via email to