Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6097#discussion_r191460316
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/KeyedProcessOperatorTest.java
 ---
    @@ -50,6 +52,30 @@
        @Rule
        public ExpectedException expectedException = ExpectedException.none();
     
    +   @Test
    +   public void testKeyQuerying() throws Exception {
    +
    +           KeyedProcessOperator<Integer, Tuple2<Integer, String>, String> 
operator =
    --- End diff --
    
    The `OneInputStreamOperatorTestHarness` is `AutoCloseable` so I would 
recommend to go with
    ```
    try(harness=...) {
        ...
    }
    ```
    And remove the explicit call to `harness.close()`. This is a nice practice 
to start enforcing in new tests as it cleans up any leaks in case of exceptions 
and stuff.


---

Reply via email to