[
https://issues.apache.org/jira/browse/FLINK-9461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16495170#comment-16495170
]
Till Rohrmann edited comment on FLINK-9461 at 5/30/18 1:38 PM:
---------------------------------------------------------------
Logically, it does not make sense to couple a connector with its user (here
{{flink-table}}). If it all, then it the user should depend on the connector or
ideally we have a common abstraction/interface living for example in
{{flink-table-connectors}} which can be implemented by a concrete connector and
dropped in dynamically.
Not sure whether I buy the argument with too many maven modules. What would be
the problem with that? It rather looks to me that making
{{flink-connector-kafka}} depend on {{flink-table}} was a kind of short cut.
was (Author: till.rohrmann):
Logically, it does not make sense to couple a connector with its user (here
{{flink-table}}). If it all, then it the user should depend on it or ideally we
have a common abstraction/interface living for example in
{{flink-table-connectors}} which can be implemented by a concrete connector and
dropped in dynamically.
Not sure whether I buy the argument with too many maven modules. What would be
the problem with that? It rather looks to me that making
{{flink-connector-kafka}} depend on {{flink-table}} was a kind of short cut.
> Disentangle flink-connector-kafka from flink-table and flink-json
> -----------------------------------------------------------------
>
> Key: FLINK-9461
> URL: https://issues.apache.org/jira/browse/FLINK-9461
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Priority: Major
> Fix For: 1.6.0
>
>
> Currently, the {{flink-connector-kafka}} module has a dependency on
> {{flink-table}} and {{flink-json}}. The reason seems to be that the module
> contains the {{KafkaJsonTableSource}} and {{KafkaJsonTableSink}}. Even though
> the {{flink-table}} and {{flink-json}} dependency are marked as optional, the
> {{flink-connector-kafka}} will still contain the table sources and sinks. I
> think this is not a clean design.
> I would propose to move the table sources and sinks into a dedicated module
> which depends on {{flink-connector-kafka}}. That way we would better separate
> dependencies and could remove {{flink-table}} and {{flink-json}} from
> {{flink-connector-kafka}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
