[
https://issues.apache.org/jira/browse/FLINK-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496279#comment-16496279
]
ASF GitHub Bot commented on FLINK-7789:
---------------------------------------
Github user pnowojski commented on a diff in the pull request:
https://github.com/apache/flink/pull/6091#discussion_r192028605
--- Diff:
flink-streaming-scala/src/main/scala/org/apache/flink/streaming/api/scala/AsyncDataStream.scala
---
@@ -71,6 +71,9 @@ object AsyncDataStream {
override def asyncInvoke(input: IN, resultFuture:
JavaResultFuture[OUT]): Unit = {
asyncFunction.asyncInvoke(input, new
JavaResultFutureWrapper(resultFuture))
}
+ override def timeout(input: IN, resultFuture:
JavaResultFuture[OUT]): Unit = {
--- End diff --
You are right, there are none :( They are definitely missing, however
simple this code is. I know this is painful but still I would insist on adding
at least some rudimentary test coverage for the new code. As it is now, if
someone would change the below invocation to `asyncFunction.timeout(null,
null)` we wouldn't have known.
Let's try to improve the situation here a little bit. The new test doesn't
have to duplicate the test cases from `AsyncWaitOperatorTest.java`, but some
most basic one that checks that expected arguments are being passed will
suffice.
> Add handler for Async IO operator timeouts
> -------------------------------------------
>
> Key: FLINK-7789
> URL: https://issues.apache.org/jira/browse/FLINK-7789
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Karthik Deivasigamani
> Assignee: blues zheng
> Priority: Major
>
> Currently Async IO operator does not provide a mechanism to handle timeouts.
> When a request times out it an exception is thrown and job is restarted. It
> would be good to pass a AsyncIOTimeoutHandler which can be implemented by the
> user and passed in the constructor.
> Here is the discussion from apache flink users mailing list
> http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/async-io-operator-timeouts-tt16068.html
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
