Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4725#discussion_r192223629
--- Diff:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
---
@@ -207,13 +238,18 @@ public void writeRecord(Row row) throws IOException {
if (batchCount >= batchInterval) {
// execute batch
+ batchLimitReachedMeter.markEvent();
--- End diff --
this seems redundant given that `flushMeter` exists. While the job is
running `batchLimit == flushMeter`, and at the end `batchLimit == flushMeter
-1` except in the exceedingly rare case that the total number of rows fits
perfectly into the batches.
---
