[
https://issues.apache.org/jira/browse/FLINK-9325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497900#comment-16497900
]
ASF GitHub Bot commented on FLINK-9325:
---------------------------------------
Github user sihuazhou commented on a diff in the pull request:
https://github.com/apache/flink/pull/5982#discussion_r192374992
--- Diff:
flink-core/src/main/java/org/apache/flink/core/fs/ClosingAtomicCreatingFSDataOutputStream.java
---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.core.fs;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.util.Preconditions;
+
+import java.io.IOException;
+
+/**
+ * This class is a {@link org.apache.flink.util.WrappingProxy} for {@link
AtomicCreatingFsDataOutputStream} that is used to
+ * implement a safety net against unclosed streams.
+ *
+ * <p>See {@link SafetyNetCloseableRegistry} for more details on how this
is utilized.
+ */
+@Internal
+public class ClosingAtomicCreatingFSDataOutputStream
+ extends AtomicCreatingFsDataOutputStream
+ implements
WrappingProxyCloseable<AtomicCreatingFsDataOutputStream> {
+
+ private final SafetyNetCloseableRegistry registry;
+ private final String debugString;
+ private AtomicCreatingFsDataOutputStream outputStream;
+
+ private volatile boolean closed;
+
+ private ClosingAtomicCreatingFSDataOutputStream(
+ AtomicCreatingFsDataOutputStream delegate,
SafetyNetCloseableRegistry registry, String debugString) throws IOException {
+ this.outputStream = delegate;
+ this.registry = Preconditions.checkNotNull(registry);
+ this.debugString = Preconditions.checkNotNull(debugString);
+ this.closed = false;
+ }
+
+ public boolean isClosed() {
+ return closed;
+ }
+
+ @Override
+ public long getPos() throws IOException {
+ return outputStream.getPos();
+ }
+
+ @Override
+ public void write(int b) throws IOException {
+ outputStream.write(b);
+ }
+
+ @Override
+ public void flush() throws IOException {
+ outputStream.flush();
+ }
+
+ @Override
+ public void sync() throws IOException {
+ outputStream.sync();
+ }
+
+ @Override
+ public void close() throws IOException {
+ if (!closed) {
--- End diff --
You are right, nice catch! 👍
> generate the _meta file for checkpoint only when the writing is truly
> successful
> --------------------------------------------------------------------------------
>
> Key: FLINK-9325
> URL: https://issues.apache.org/jira/browse/FLINK-9325
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.5.0
> Reporter: Sihua Zhou
> Assignee: Sihua Zhou
> Priority: Major
>
> We should generate the _meta file for checkpoint only when the writing is
> totally successful. We should write the metadata file first to a temp file
> and then atomically rename it (with an equivalent workaround for S3).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
