Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/6104#discussion_r192376031
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/CEPITCase.java ---
    @@ -383,6 +386,100 @@ public String select(Map<String, List<Event>> 
pattern) {
                env.execute();
        }
     
    +   @Test
    +   public void testSimpleKeyedPatternEventTimeWithSideOutput() throws 
Exception {
    --- End diff --
    
    How about to simplify the test a bit? 
    
    I would be in favour of implementing this test with `OperatorTestHarness` 
(in CepOperatorTest). This way we it is way easier to follow which events are 
late.
    
    Also I would use a simpler Pattern here... Don't see a reason for using 3 
part one.


---

Reply via email to